Reduce usage of shared_ptr in the core #1248
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Laurynas Jagutis <[email protected]>
Signed-off-by: Laurynas Jagutis <[email protected]>
Signed-off-by: Laurynas Jagutis <[email protected]>
Signed-off-by: Laurynas Jagutis <[email protected]>
…test Signed-off-by: Laurynas Jagutis <[email protected]>
Signed-off-by: Laurynas Jagutis <[email protected]>
Signed-off-by: Laurynas Jagutis <[email protected]>
Signed-off-by: Laurynas Jagutis <[email protected]>
|
mgovers
reviewed
Jan 12, 2026
| static constexpr auto is_iterative = true; | ||
|
|
||
| IterativeCurrentPFSolver(YBus<sym> const& y_bus, std::shared_ptr<MathModelTopology const> const& topo_ptr) | ||
| IterativeCurrentPFSolver(YBus<sym> const& y_bus, MathModelTopology const& topo_ptr) |
Member
There was a problem hiding this comment.
this is no longer a pointer
Suggested change
| IterativeCurrentPFSolver(YBus<sym> const& y_bus, MathModelTopology const& topo_ptr) | |
| IterativeCurrentPFSolver(YBus<sym> const& y_bus, MathModelTopology const& topo) |
| private: | ||
| // cache topology | ||
| std::shared_ptr<MathModelTopology const> math_topology_; | ||
| MathModelTopology const& math_topology_; |
Member
There was a problem hiding this comment.
member types should not be const& as it prevents it from being copyable and movable. Instead, please use either a raw pointer const* or a std::reference_wrapper
| data_gain_(y_bus.nnz_lu()), | ||
| delta_x_rhs_(y_bus.size()), | ||
| x_(y_bus.size()), | ||
| sparse_solver_{y_bus.shared_indptr_lu(), y_bus.shared_indices_lu(), y_bus.shared_diag_lu()}, |
Member
There was a problem hiding this comment.
i even think we can remove shared_indptr_lu and shared_indices_lu and shared_diag_lu altogether
Comment on lines
+475
to
+476
| auto const& row_indptr = row_indptr_; | ||
| auto const& col_indices = col_indices_; |
Member
There was a problem hiding this comment.
you may want to use the member version in the rest of the code as well. the utility declaration auto const& was only to remove the need to specify pointer everywhere
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #994
So far using references, reference wrappers to replace shared_ptr.